feat: support for Latvian eID Eparaksts #3826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
martinsc seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
OskarsPakers
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3826 +/- ##
==========================================
- Coverage 78.17% 78.05% -0.12%
==========================================
Files 362 361 -1
Lines 25433 25355 -78
==========================================
- Hits 19881 19791 -90
- Misses 4030 4046 +16
+ Partials 1522 1518 -4 ☔ View full report in Codecov by Sentry. |
OskarsPakers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is the implementation of Latvian electronic ID provider eParaksts. It features two authentication methods and two identity providers (implemented in a single file) eparaksts - authentication with ID card and card reader, eparaksts-mobile - with eParaksts mobile app
Eparaksts developer documentation here.
I have read, but not following commit prefixes, let me know if this is a showstopper.
I haven`t created a design document as this seems like a straightforward implementation.
Fixes #3859
Configuration needed for this identity provider:
scope: "urn:lvrtc:fpeil:aa"
issuerURL: "https://eidas.eparaksts.lv"
Let us know whan needs to be added./changed/
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.